From 59246091e1270f3ddf8f9078cbe4c271390962fa Mon Sep 17 00:00:00 2001
From: Frank Fegert
Date: Mon, 11 May 2009 21:29:58 +0000
Subject: [PATCH] - added checks for PHP memory_limit for mod_php and php-cli.
---
install.php | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 80 insertions(+), 4 deletions(-)
diff --git a/install.php b/install.php
index 11a9adb..1c68afe 100644
--- a/install.php
+++ b/install.php
@@ -92,7 +92,6 @@ if ($old_tsm_monitor_version == $config["tsm_monitor_version"]) {
}
// dsmadmc binary path
-$input["path_dsmadmc"] = $configarray["settings"]["path_dsmadmc"];
$input["path_dsmadmc"]["name"] = "dsmadmc Binary Path";
$input["path_dsmadmc"]["desc"] = "The path to the TSM admin client binary.";
$which_dsmadmc = findPath("dsmadmc", $config["search_path"]);
@@ -105,7 +104,6 @@ if (isset($configarray["settings"]["path_dsmadmc"])) {
}
// php/php5 binary path
-$input["path_php"] = $configarray["settings"]["path_php"];
$input["path_php"]["name"] = "PHP Binary Path";
$input["path_php"]["desc"] = "The path to the PHP binary.";
$which_php = findPath("php", $config["search_path"]);
@@ -121,7 +119,6 @@ if (isset($configarray["settings"]["path_php"])) {
}
// logfile path
-$input["path_tmlog"] = $configarray["settings"]["path_tmlog"];
$input["path_tmlog"]["name"] = "TSM Monitor Logfile Path";
$input["path_tmlog"]["desc"] = "The path to the TSM Monitor log file.";
if (isset($configarray["settings"]["path_tmlog"])) {
@@ -317,7 +314,7 @@ if ($_REQUEST["step"] == "90") {
$resStr = "";
$capStr = "";
- if (file_exists($file)) {
+ if (file_exists($file) && is_file($file)) {
$resStr = "[FOUND] ";
$capStr = "
[OK: FILE FOUND]";
} else {
@@ -351,6 +348,85 @@ if ($_REQUEST["step"] == "90") {
If you did choose to upgrade from a previous version of TSM Monitor, the
database will also be upgraded by clicking "Finish".
+
+
+ PHP memory_limit settings: Default or configured PHP limits
+
+
+
+
+ Webserver:
+ |
+
+ $mem_val $mem_unit
+ |
+
+ [$mem_text $mem_recommend M recommended]
+ |
+ ";
+
+ if ($mem_cli_val < $mem_cli_recommend) {
+ $mem_color = "#FF0000";
+ $mem_text = "Warning: at least";
+ } else {
+ $mem_color = "#008000";
+ $mem_text = "OK:";
+ }
+ echo "
+
+
+ Command line:
+ |
+
+ $mem_cli_val $mem_cli_unit
+ |
+
+ [$mem_text $mem_cli_recommend M recommended]
+ |
+
";
+ ?>
+
+
+
+
+ NOTE: Depending on the volume of data gathered from your
+ TSM servers by TSM Monitor, the PHP memory_limit settings shown above may
+ not be sufficient. Please edit your php.ini configuration files to at least
+ match the recommended values shown above and restart your webserver. This
+ has to be done manually and is not part of the TSM Monitor configuration!
+